Add CI pipeline step to run the race detector against the tests #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krebernisak
reviewed
Jan 10, 2022
|
@skudasov is this a flaky test (e2e/smoke)? https://github.com/smartcontractkit/chainlink-solana/runs/4761612631?check_suite_focus=true This PR (monitoring service fix) should not influence the ocr2 smoke test, right? |
Not flaky tests, it's because the contracts changed, and I haven't been able to get an updated core image. So the test will continue to fail until the core version in the e2e tests are updated. Update: e2e tests were fixed. rebasing should bring those changes in for the CI |
krebernisak
force-pushed
the
test-race
branch
from
3ddf2d0 to
80d67f9
Compare
krebernisak
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.